some triage fixes #11333
Merged
some triage fixes #11333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think it's relevant, a warning is more appropriate. Easier to just maintain the order. Closes #4681
This let's us specify exactly which snapshot a given note to update after snapshot is for. Closes #2483
pcwalton says this is right, and it looks right to me too. Closes #4731
Obviously everything is unstable, but these particularly so, and they will likely remain that way. Closes #10239
|
I removed the contentious commits; moving arg name checking to typeck turned out to be not as easy (requires walking the types of the arguments to catch duplicate names in closure decls). |
bors
added a commit
that referenced
this pull request
Jan 6, 2014
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 14, 2023
…p1995 Do not bless by default in ui tests This restores the default behaviour to check the `.stderr`, it was changed in rust-lang#11239 to bless by default in `cargo test` (unless in github actions), but check by default in `cargo uitest` which is fairly confusing It also meant `cargo uitest -F internal` no longer worked `--bless` prevents the use of `Args::test` but we can look at reintegrating with that after `@oli-obk's` vacation r? `@flip1995` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.